exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
59 stars 24 forks source link

Update: Upgrade 2x YUI2 tabviews to YUI3 #1512

Closed exponentcms closed 4 years ago

exponentcms commented 4 years ago

Not only do we need to update the javascript in the templates, but create a css for the new style labels.

exponentcms commented 4 years ago

(from [05e3b563e5ec028dea6f5eb88953f1288e725c89]) Update alll but ecom tabviews to YUI3. All now use a animated loading bar and follow a standard format [#361] https://github.com/exponentcms/exponent-cms/commit/05e3b563e5ec028dea6f5eb88953f1288e725c89

exponentcms commented 4 years ago

(from [5167d99271f30adb062ce29e493b99f6f94bff04]) Update YUI3 Tabview style to better mimic recent YUI2 style used [#361] https://github.com/exponentcms/exponent-cms/commit/5167d99271f30adb062ce29e493b99f6f94bff04

exponentcms commented 4 years ago

(from [148a262d18308d4072a61955e731a92aa755699c]) Removes commented out YUI2 Tabview lines [#361] https://github.com/exponentcms/exponent-cms/commit/148a262d18308d4072a61955e731a92aa755699c

exponentcms commented 4 years ago

(from [dcdb1f29fe6ed8bb677cbb6b003961910363aa4d]) Implements tabview history for tabbed containers and tabbed text module views in addition to the site configuration view pushed earlier [#361 ] https://github.com/exponentcms/exponent-cms/commit/dcdb1f29fe6ed8bb677cbb6b003961910363aa4d

exponentcms commented 4 years ago

(from [428a55207858d30c88acc57128ecbcccbe650c54]) Revert tabbed container & text module to tabview WITHOUT history, #1 selecting the 1st tab always scrolls to top of page, #2 all tabview containers have the same url, so multiple tabviews on same page all have same tab anchor reference [#361] https://github.com/exponentcms/exponent-cms/commit/428a55207858d30c88acc57128ecbcccbe650c54

exponentcms commented 4 years ago

All tabview implementations are upgraded to YUI3 except for:

these have a bit more complicated/extra code and I don’t want to break them.

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

The only remaining yui2-tabview's are in ecommerce, report, & a couple e-commerce search views. Since I don't 'do' e-commerce, we'll put this back in the to-do stack.

exponentcms commented 4 years ago

The only remaining yui2 tabviews are search/topSearchReport.tpl and report/show_payment_summary.tpl which have an embedded chart which gets mashed with a yui3 tabview/chart.

exponentcms commented 4 years ago

(from [3bfe22532cafd3e688cce7451332b649e4c8e1c4]) Cleans up some e-commerce errors/views and moves most to yui3 tabviews, adds a few more items to the ecommerce sample database which are necessary to get it up and running [#361] https://github.com/exponentcms/exponent-cms/commit/3bfe22532cafd3e688cce7451332b649e4c8e1c4

exponentcms commented 4 years ago

Changing title to reflect we only have two views left with the charts issue

exponentcms commented 4 years ago

Forgot to change the title

exponentcms commented 4 years ago

(from [ec67e73da12ae23cc861f141d01b93964b801b34]) Converts remaining yui2-tabviews to yui3, however it leaves the chart problem which is partially the same problemas with ckeditor checkbox, & calendar widgets in a tabview [#361 state:resolved milestone:2.0.9 responsible:dleffler] https://github.com/exponentcms/exponent-cms/commit/ec67e73da12ae23cc861f141d01b93964b801b34

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/361