Bug: Buttons on pages don't always move to the expected/correct page`

exponentcms / exponent-cms

Content Management, Simple.

exponentcms.org

GNU General Public License v2.0

59 stars 24 forks source link

Bug: Buttons on pages don't always move to the expected/correct page` #1513

Open exponentcms opened 4 years ago

exponentcms commented 4 years ago

In some instances, the buttons on forms pages (configure, manage, etc...) don't take you where you'd expect (Save, Cancel, etc...)

exponentcms commented 4 years ago

I'm paranoid that expHistory may need a good scrub. Not sure we always operate within the global $history object (within expHistory, not the calling module)? And we also rely on session variables (between pages)?

There is also some inconsistency in setting the history marker (set method) within methods (esp. showall, show, etc...)

We may need to come up with a better paradigm for layering history 'types' such as viewable, editable, configurable(?is this even valid?), managable, not_editable, etc...

exponentcms commented 4 years ago

Notes:

the home page never (seems to) get added to the history lists
the expHistory->set() method is called numerous times per page for each module view
however the expRouter->routeRequest() method is only called one per page
4 $router->url_type of base, page, action, post, & malformed
2 $router->url_style of sef, & query

exponentcms commented 4 years ago

(from [c49758a4d6510ced96e9d94d8fb2592f4c5721a6]) Attempts to fix problem where Buttons on pages don't always move to the expected/correct page, we now do a better job of flagging and adding the home page to the history (never was being added) [#645] https://github.com/exponentcms/exponent-cms/commit/c49758a4d6510ced96e9d94d8fb2592f4c5721a6

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

(from [38fe076f469f653ca0883af41252a100b9176515]) Fixes issue where 'Done' button on form record 'show' view didn't take you back to the expected/correct page [#645] https://github.com/exponentcms/exponent-cms/commit/38fe076f469f653ca0883af41252a100b9176515

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

[bulk edit]

exponentcms commented 4 years ago

Lighthouse URL: https://exponentcms.lighthouseapp.com/projects/61783/tickets/645