search

exponentcms / exponent-cms

Content Management, Simple.
exponentcms.org
GNU General Public License v2.0
59 stars 24 forks source link

Cart contents showing for all users #1538

Closed BJKline03 closed 3 years ago

BJKline03 commented 3 years ago

Also on https://buyplasmaparts.com/ the show cart link shows the contents of the cart regardless if the user is logged in or not. This also started happening since the upgrade to 2.6. To test this, add an item (for example 220818) then go to another browser, and open the site. The cart link then shows the items you added.

exponentcms commented 3 years ago

I'm not following why this is an issue?

BJKline03 commented 3 years ago

Prior to 2.6 a user had no indication that another user had put items in the cart. Now users on two different devices on two different networks can see the cart contents and can keep adding items.

dleffler commented 3 years ago

I think I've got the fix for this by adding parentheses to the new sql select

exponentcms commented 3 years ago

v2.6.0patch1 has been release with this fix