search

express-labs / pure-react-carousel

A highly impartial suite of React components that can be assembled by the consumer to create a carousel with almost no limits on DOM structure or CSS styles. If you're tired of fighting some other developer's CSS and DOM structure, this carousel is for you.
https://express-labs.github.io/pure-react-carousel/
MIT License
1.68k stars 161 forks source link

Add image loading error handling capabilities to ImageWithZoom #386

Closed carles-codony-manomano closed 2 years ago

carles-codony-manomano commented 2 years ago

Describe the feature you'd like: ImageZoom adds the zoom functionality, but removes the ability to handle loading errors. Then as users we have to choose between handling loading errors but not having zoom, or having zoom but not being able to handle loading errors.

The need to handle loading errors is still present when using the zoom functionality, to give visual feedback to the end user as to what happened.

Suggested implementation:

Add the renderError and onError props so they work in the same way.

Describe alternatives you've considered:

None that I could imagine

Teachability, Documentation, Adoption, Migration Strategy:

The docs don't have a props table for ImageWithZoom, so it could be added with the error handling props included, the same as the ones for Image.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

pankaj2961 commented 2 years ago

I would like to see this feature implemented. Can I pick this issue and work on it ?

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 2 years ago

This issue has been automatically closed becuase it has not had recent activity.