search

express-vue / vue-pronto

Rendering Engine for turning Vue files into Javascript Objects
Apache License 2.0
20 stars 12 forks source link

#170 Add server configuration to Vue strings received in appConfig #172

Closed andoniabedul closed 3 years ago

andoniabedul commented 3 years ago

Related to the issue #170

danielcherubini commented 3 years ago

This is good however this introduces a breaking change.

Could you do a check for config.server then use that else use config.app?

danielcherubini commented 3 years ago

I’m somewhere where there’s very little internet. So I’ll look at this in a week.

On Thu, Dec 31, 2020, at 3:03 PM, [BR]John_Magdy wrote:

@Zorono approved this pull request.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/express-vue/vue-pronto/pull/172#pullrequestreview-560356599, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBQ4LQX6HEVZWCOOK7VSTSXSADBANCNFSM4U3CFJQA.

danielcherubini commented 3 years ago

This is still missing a unit test, I can't merge it without one.

andoniabedul commented 3 years ago

I will do it this week

andoniabedul commented 3 years ago

It was added the test for server string configuration. Sorry for the delay (christmas, new year and all that pagan stuff)

danielcherubini commented 3 years ago

Thanks!