Closed andoniabedul closed 3 years ago
This is good however this introduces a breaking change.
Could you do a check for config.server then use that else use config.app?
I’m somewhere where there’s very little internet. So I’ll look at this in a week.
On Thu, Dec 31, 2020, at 3:03 PM, [BR]John_Magdy wrote:
@Zorono approved this pull request.
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/express-vue/vue-pronto/pull/172#pullrequestreview-560356599, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADBQ4LQX6HEVZWCOOK7VSTSXSADBANCNFSM4U3CFJQA.
This is still missing a unit test, I can't merge it without one.
I will do it this week
It was added the test for server string configuration. Sorry for the delay (christmas, new year and all that pagan stuff)
Thanks!
Related to the issue #170