search

express-vue / vue-pronto

Rendering Engine for turning Vue files into Javascript Objects
Apache License 2.0
20 stars 12 forks source link

Adds Webpack Renderer #89

Closed danielcherubini closed 5 years ago

danielcherubini commented 5 years ago

This is a big one.. it's probably best to pull it and run it locally

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into develop will decrease coverage by 0.69%. The diff coverage is 89.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop      #89     +/-   ##
==========================================
- Coverage    90.35%   89.66%   -0.7%     
==========================================
  Files           11       13      +2     
  Lines          456      619    +163     
==========================================
+ Hits           412      555    +143     
- Misses          44       64     +20
Impacted Files Coverage Δ
lib/utils/stream.js 100% <100%> (ø) :arrow_up:
lib/renderer/renderer-vueify.js 90.83% <100%> (ø)
lib/utils/head.js 98.76% <100%> (+0.01%) :arrow_up:
lib/utils/index.js 100% <100%> (ø) :arrow_up:
lib/index.js 100% <100%> (ø) :arrow_up:
lib/renderer/renderer-webpack.js 88.19% <88.19%> (ø)
lib/utils/layout-webpack.js 90% <90%> (ø)
lib/utils/cache.js 85.71% <0%> (-1.79%) :arrow_down:
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 747db3c...cd92b16. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #89 into develop will increase coverage by 2.13%. The diff coverage is 90.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #89      +/-   ##
===========================================
+ Coverage    90.35%   92.48%   +2.13%     
===========================================
  Files           11       14       +3     
  Lines          456      599     +143     
===========================================
+ Hits           412      554     +142     
- Misses          44       45       +1
Impacted Files Coverage Δ
lib/utils/cache.js 100% <ø> (+12.5%) :arrow_up:
lib/utils/stream.js 100% <100%> (ø) :arrow_up:
lib/renderer/renderer-vueify.js 90.83% <100%> (ø)
lib/utils/config.js 100% <100%> (ø)
lib/utils/head.js 98.76% <100%> (+0.01%) :arrow_up:
lib/utils/index.js 100% <100%> (ø) :arrow_up:
lib/index.js 100% <100%> (ø) :arrow_up:
lib/utils/promiseFS.js 85.71% <85.71%> (ø)
lib/renderer/renderer-webpack.js 88.88% <88.88%> (ø)
lib/utils/layout-webpack.js 90% <90%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 747db3c...66d70b8. Read the comment docs.

danielcherubini commented 5 years ago

@nick-fytros you mean minor.. since this isn't a deprecation..

what i can do is just do it locally, or use a pre-release