search

express42 / postgresql_lwrp

Express 42 postgresql cookbook
MIT License
55 stars 16 forks source link

Libraries::ResourcePostgresqlCloudBackup: default argument value should ... #15

Closed Bregor closed 9 years ago

Bregor commented 9 years ago

...be nil because of set_or_return behaviour:

  if arg == nil && self.instance_variable_defined?(iv_symbol) == true

In this way, assigned value will be returned only if default value will be nil

sample commented 9 years ago

Right, but in pr you set required: true for command_prefix

Bregor commented 9 years ago

Sorry for this. As far as I can understand fresh chef sources (https://github.com/chef/chef/blob/2603e2153d6ab50179d2278025a51579edb9033f/lib/chef/mixin/params_validate.rb#L100-L107) this is not necessary anymore. Anyway, fixed in fdfa1c0cc7f10635b4abd8aec91af492e8762ca2