search

expressGNN / ExpressGNN

103 stars 26 forks source link

test_data in get_batch_by_q ? #5

Open ma-biao opened 3 years ago

ma-biao commented 3 years ago

In get_batch_by_q of dataset.py :

if validation:
    fact_ls = self.valid_fact_ls
else:
    fact_ls = self.test_fact_ls

So the fact_ls is either valid_data or test_data, and in E-step of train loop, test_data is used for train. Is that test data leakage? Looking forward to your reply.

@expressGNN @yuyuz