expressjs / body-parser

Node.js body parsing middleware
MIT License
5.45k stars 727 forks source link

Update Github Actions Workflow #545

Closed Phillip9587 closed 1 month ago

Phillip9587 commented 1 month ago

I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:

  1. Node.js Installation in the Matrix Test Run:

    • Currently, the workflow uses nvm to install Node.js versions.
    • It might be worth considering switching to the official actions/setup-node action. This action can leverage cached Node.js versions from the runner, which could improve efficiency and speed up the CI pipeline.
  2. Deprecation of Artifact Actions v3:

    • The actions/upload-artifact@v3 and actions/download-artifact@v3 actions are being deprecated as of November 30, 2024 (GitHub Deprecation Notice).
    • These actions should be updated to their latest versions to ensure continued functionality in the CI workflow.
Phillip9587 commented 1 month ago
  1. The Coverage setup could also be optimized:
    • Currently, the workflow uses the coverallsapp/github-action@master which points to v1 of this action. This v1 action uses node16 as runtime which is deprecated.
Phillip9587 commented 1 month ago
  1. Minimum token permissions for the GITHUB_TOKEN: