search

expressjs / compression

Node.js compression middleware
MIT License
2.77k stars 241 forks source link

feat: support for brotli #194

Open bjohansebas opened 4 weeks ago

bjohansebas commented 4 weeks ago

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

bjohansebas commented 4 weeks ago

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

sardeeplakhera commented 3 weeks ago

@bjohansebas @blakeembrey Is there a tentative date for merging this?

bjohansebas commented 3 weeks ago

@sardeeplakhera I hope it can be merged soon, although there’s still some time needed to ensure that everything works correctly.

sardeeplakhera commented 3 weeks ago

Thanks, @bjohansebas! Do you think first week of December could be a realistic target for the release? Or is there anything else that might push it back further?

bjohansebas commented 3 weeks ago

@sardeeplakhera i think a new patch version for this package could be ready by December. Currently, this work is more like a proposal for version 1.8.0 (see #189)

Fonger commented 3 weeks ago

Thank you the maintenance team! Glad to see it finally gets some progress.

bjohansebas commented 6 days ago

hi @wesleytodd @blakeembrey, I've updated the options to avoid using object-assign, would love to hear your feedback