expressjs / cookie-parser

Parse HTTP request cookies
MIT License
1.96k stars 220 forks source link

ci: Use GITHUB_OUTPUT envvar instead of set-output command #100

Closed arunsathiya closed 6 months ago

arunsathiya commented 10 months ago

save-state and set-output commands used in GitHub Actions are deprecated and GitHub recommends using environment files.

This PR updates the usage of ::set-output to "$GITHUB_OUTPUT"

Instructions for envvar usage from GitHub docs:

https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#setting-an-output-parameter

UlisesGascon commented 6 months ago

@inigomarquinez can u have a look?

inigomarquinez commented 6 months ago

Approved! In fact, in other PRs we already use the approach suggested by @arunsathiya . Thanks for the catch!