Fixed signed cookie value assigning with undefined or false - Githubissues

expressjs / cookie-parser

Parse HTTP request cookies

MIT License

1.96k stars 220 forks source link

Fixed signed cookie value assigning with undefined or false #109

Closed sarraf1996 closed 1 month ago

sarraf1996 commented 1 month ago

This is a bug fix which is related to issue #108 . Detailed description can be found over the issue about the bug details.

Fixed signed cookie value assigning with undefined or false when cookie secret is updated.
Handled and fixed the validation of undefined and false values in signedCookies (obj, secret){} function of cookie-parser module in such a way that all signed cookies with invalid signatures can be ignored and should neither be included in req.cookies nor in req.signedCookies objects as they become invalid post cookie secret updation.

dougwilson commented 1 month ago

This pull request breaks the documented behavior