search

expressjs / cors

Node.js CORS middleware
MIT License
6.04k stars 467 forks source link

include types with package #235

Open jamiehaywood opened 3 years ago

jamiehaywood commented 3 years ago

Would you consider including the types as part of the package? I appreciate that you can get them from the @types/cors package, but it would be a nicer dev xp to have them included 🙂

dougwilson commented 3 years ago

As long as we have a volunteer that understands typescript to be available to hrlp with any issues, review changes to ensure the types are updated correctly, etc. This is important as with the separate package an issue with the types can be fixed independently of the package; including them in the package means they need to be accurate with every publish of the package, so need someone who understands typings to be on call for any changes that need to land.

jamiehaywood commented 3 years ago

I would be happy to volunteer. I use TypeScript extensively at work and in personal projects.

dougwilson commented 3 years ago

Awesome @jamiehaywood ! I would think probably the best way to get started would be to help get closed the open issues over at https://github.com/DefinitelyTyped/DefinitelyTyped/issues so then we have the @types/cors at what would get included here without any open issues from folks. Then we can copy them into this repo and go forward. Does that sound like a good plan? If not, let me know what you think the plan should be 👍

jamiehaywood commented 3 years ago

Yep that plan sounds good - I will take a look over the next couple of the days & report back!

monsieurnebo commented 2 years ago

Hi guys,

Any news about this project?