search

expressjs / discussions

Public discussions for the Express.js organization
62 stars 14 forks source link

EFI: Codeowners #178

Open sheplu opened 6 months ago

sheplu commented 6 months ago

Motivation

Automation can only be effective if setup correctly. Relying on Codeowners can great help the automation allowing us to automatically notify specific people when a Pull Request is opened on specific part of the project. It can also be used to notify specific team depending on the change, for example a security group or technical writer if this only change some documentation

Expectation

Implement Codeowners files in each repositories and setup them accordingly

Implementation

Setup codeowner

Status

Part: Organization

Draft

In a project, all changes are not equal and the risk is not the same. Contributions to the core package need to be reviewed extensively to ensure the highest quality but other parts are less critical. By using codeowners file, we can automatically manage this risk and allocate specific teams to review pull requests. For example, a change only targeting documentation or test could be reviewed and validated by the triager team (or another specific team) and does need less approval (maybe only 1-2) while changes in the core of the package may require more validations (3-4 approvals by specific members)

wesleytodd commented 6 months ago

How do we see this working with the Captains? I guess I would think that each captain would also be a code owner in the repo. I guess then we would need to setup those files and approval rules?