search

expressjs / discussions

Public discussions for the Express.js organization
59 stars 13 forks source link

Express 5.0 - last push! #233

Open UlisesGascon opened 2 months ago

UlisesGascon commented 2 months ago

This issue includes a reference to all the PRs/issues or pending tasks for Express and dependencies needed to finally ship Express@5.

Rules (WIP):

If you think that any reference is missing, please edit this comment (@expressjs/express-tc) or reply with a comment if you don't have the permissions.

Pending things (Express):

Pending things (Dependencies):

Pending things (Documentation):

Discussions pending:

New

Under Investigation

Decisions made:

Not in 5.x

Future Minors

wesleytodd commented 2 months ago

Awesome! Was this list pulled from those labels? One thing we probably need to add as a TODO is to go through all of the direct dependencies and ensure they all have correctly triaged ones which should land before v5, or did you do that as well? It is hard to tell from the list but I dont see any body parser issues in here and I could have sworn there was some pending work to land in there (and that is likely not the only one if we haven't explicitly checked them all)?

UlisesGascon commented 2 months ago

Awesome! Was this list pulled from those labels?

This was done manually. I quickly reviewed the express and expressjs.com repositories. If anything is missing from dependencies, please feel free to add them. The list may not be exhaustive at this point, but it's a great starting point and compass to help us focus on v5.x. You made a great suggestion with this approach :raised_hands:

Let's also see if the @expressjs/triagers can help us find missing items on the list and assist in reviewing PRs and taking leadership in some of them (I see a few PRs that require conflict resolution, updates...).

CBID2 commented 2 months ago

Can I do the "Add the blog one" @UlisesGascon?

wesleytodd commented 2 months ago

Yeah this is great! Absolutely agree with getting folks involved in taking ownership of them. Go team!

If anything is missing from dependencies, please feel free to add them.

Ok yeah this was my main concern. I knew for sure there is router stuff which is why I started there with the labels, but I think there is more in the other few. So if anyone wants to take point on reviewing the deps we own which are "direct deps" of express that would be awesome. Specifically I think each repo needs to address if there are any pending breaking changes which look like they were ready to land (if they are too contentious or too incomplete then we should not land them now) or if there is a pre-existing major version branch with work left to do on it (which is the case in a few for sure). For that we need to catalog that work here so we make sure we don't miss anything.

jonchurch commented 2 months ago

Active dev branch for v5 is 5.x, correct? As opposed to 5.0 which would be a release branch?

mertcanaltin commented 2 months ago

Can I do the "Add the blog one" @UlisesGascon?

I can help you 🚀

mertcanaltin commented 2 months ago

Add support for Node@22 in the CI (no leader), would like to work with this topic

UlisesGascon commented 2 months ago

Can I do the "Add the blog one" @UlisesGascon?

I think that @chrisdel101 is actively working on it, maybe we can provide them more support.

Aside of active development for sure you (@CBID2 @mertcanaltin) can work on:

Add support for Node@22 in the CI (no leader), would like to work with this topic.

I think that maybe @rxmarbles is working on it, based on slack comment

wesleytodd commented 2 months ago

Active dev branch for v5 is 5.x, correct? As opposed to 5.0 which would be a release branch?

Yeah exactly. That said I have gotten confused a few times and I think this is one case where we would benefit from automation and some really clear and simple docs.

Yaminyam commented 1 month ago

I'm very excited about the new version of express being released! https://github.com/expressjs/generator I think it would be better if this repo was also maintained. I think that the current code written using syntax prior to ES2015 is very outdated. (ref: https://github.com/expressjs/generator/pull/200)

wesleytodd commented 1 month ago

Hey @Yaminyam, that package is on our radar but we need to do the necessary here first. I believe there is a tracking issue for it here: https://github.com/expressjs/discussions/issues/197

wesleytodd commented 1 month ago

@jonchurch do you think this needs to be added to the list above? https://github.com/expressjs/express/issues/4851

EDIT: just to keep the records, this one is related as well I think https://github.com/expressjs/express/pull/4852

wesleytodd commented 1 month ago

I reviewed the remaining open things in body-parser. I added them to the list here, but likely will want to update the linked v2 PR as well. I dont have enough remaining battery on this plane to be able to start work on them, and also I think some are a bit ambigious as to what we need to do to get it across the finish line. Would love if folks could click through some of the ones I added and add any insight or thoughts they have on them and if we need to land them.

jdhiro commented 2 days ago

Why are there so many "bonus" dependencies on the 5.0 release the community has been waiting on for YEARS? (Brotli support?!)

5.0 literally needs two things:

That's it. Add those and ship it -- for the love of God.