search

expressjs / express

Fast, unopinionated, minimalist web framework for node.
https://expressjs.com
MIT License
65.73k stars 16.35k forks source link

Add committers to expressjs.com repo #6057

Open crandmck opened 1 month ago

crandmck commented 1 month ago

Based on the Contributor Guide, several contributors should be given commit rights to the website repo:

UlisesGascon commented 1 month ago

+1 from my side. I will update this PR https://github.com/expressjs/express/pull/6033 with the new commiters (tomorrow) :+1:

bjohansebas commented 4 weeks ago

@UlisesGascon can I open the PR to nominate them? Or do you prefer to update the current PR?

UlisesGascon commented 3 weeks ago

Feel free to create a new one with the same format @bjohansebas :+1:

bjohansebas commented 1 day ago

According to what i understood in the meeting, they can be committers without being added to the list.

wesleytodd commented 17 hours ago

Yeah, as long as you all as the captains agree, then no need to add to the list or open an issue here. One thing we should be careful about is that the website doesn't have a release step, any merge is a release. So we should make sure folks are all aligned on the steps needed to land a PR. Maybe even additional branch protections to add "process" to it, but that is all up to you all imo.

bjohansebas commented 17 hours ago

Yep, that's what I was thinking, and maybe it's a good idea to apply a PR policy, like node.js has on its website.

ref: https://github.com/nodejs/nodejs.org/blob/main/CONTRIBUTING.md#pull-request-policy

bjohansebas commented 16 hours ago

This already exists discreetly in the current Express contribution file in general, it might be a good idea to make it more visible and add it to the website's contribution file.