search

expressjs / express

Fast, unopinionated, minimalist web framework for node.
https://expressjs.com
MIT License
65.73k stars 16.35k forks source link

cleanup: remove unnecessary require for global Buffer #6146

Closed Phillip9587 closed 1 week ago

Phillip9587 commented 2 weeks ago

The Buffer object is globally available in Node.js, so there is no need to explicitly require it.

Phillip9587 commented 1 week ago

@wesleytodd Does this require an entry in HISTORY.md? The changes don't alter any behavior; they simply remove unnecessary requires of the global buffer.

Edit: I just read your comment on #6147 and #6176 and just added the entry

wesleytodd commented 1 week ago

Thanks! yeah we will be automating that, but I think there is some question still of how deep we want to go on the automation, so it has not happened yet. Just making sure we don't make a mistake by abandoning the process even if it is a bad process 😄 .