search

expressjs / expressjs.com

https://expressjs.com
Other
5.23k stars 1.42k forks source link

Nav links do not reppear after resizing #1499

Closed chrisdel101 closed 1 month ago

chrisdel101 commented 2 months ago

If while at the @media (max-width: 899px) breakpoint the <div id="mobile-menu"> hamburger menu is opened and then closed, then the screen is enlarged, the nav bar links to do reappear.

https://github.com/expressjs/expressjs.com/assets/14151974/fd50b225-51ad-447d-a136-e26bc3172ea5

crandmck commented 2 months ago

Thanks, is this a dup of #1398 ?

chrisdel101 commented 2 months ago

yes, i believe so. after looking at 1398 it seems to be the exact same issue. if that 2023 PR was successful, for some reason the issue is still persisting for me. (or it’s a different cause). if you want to keep it open i can look at it after my other two issues are complete?

edit: i see a PR might be incoming. so scratch that.

crandmck commented 2 months ago

And... here it is: https://github.com/expressjs/expressjs.com/pull/1502 Thoughts?