search

expressjs / expressjs.com

https://expressjs.com
Other
5.25k stars 1.46k forks source link

Update best-practice-security with TLS Cipher Suites.md #1534

Closed stellastrareviews closed 3 months ago

netlify[bot] commented 3 months ago

Deploy Preview for expressjscom-preview ready!

Name Link
Latest commit be4d26c53ae36f017e4051b69f51842e13ef6ea4
Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/667a9c16123b350008ec9d84
Deploy Preview https://deploy-preview-1534--expressjscom-preview.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

chrisdel101 commented 3 months ago

Hi @stellastrareviews. As this is an unsolicited PR with no text body description whatsoever I'm inclined to close this. I'll ask for @crandmck to take a look first.

crandmck commented 3 months ago

Thanks @chrisdel101 ... I'm not a security expert, so I have no idea if this is good advice. It's important to provide good security guidance, so if it IS, then we should include it.

Perhaps @jonchurch can advise? Otherwise, then, yes, we can just close this.

ctcpip commented 3 months ago

Suggest closing without merging. Unsolicited PR recommending a proprietary tool which is redundant for the recommendations already provided.