search

expressjs / generator

Express' application generator
MIT License
1.82k stars 548 forks source link

lack of partials support for handlebars #162

Open alexanderankin opened 7 years ago

alexanderankin commented 7 years ago

The way the --hbs options currently works doesnt support partials, i suspect that it might be possible to change that without the use of an additional package, but there was a package designed specifically with this in mind, so i figured id use that instead.

In #161 I jumped the gun on the discussion phase and already submitted a replacement of the handlebars package which DG also maintains, and coded up the rest of the suggestions he laid out there. My plan is to resubmit a PR next week taking into account any feedback i get here, and also see if i can figure out how to get DG's handlebars package to support partials the way the package i found does.

spaceraccoon commented 6 years ago

Was there any progress on this?

alexanderankin commented 6 years ago

short answer no

The issue was that the only considered reliable packages are those in the purview of the expressjs github organization which @dougwilson also manages, and he raises valid concerns about the huge matrix of supported platforms and versioning that come inherently as adding a node package into the mix from outside.

I didn't feel comfortable rewriting or augmenting existing package at the time, but for now I'd suggest installing the branch with the external package, running it to see the output it contains, copy/pasting the output to a github gist, reinstalling the generator from npm and just copy and pasting from the gist.

spaceraccoon commented 6 years ago

Got it, thanks!

On Thu, Nov 30, 2017 at 5:21 PM David Ankin notifications@github.com wrote:

short answer no

The issue was that the only considered reliable packages are those in the purview of the expressjs github organization which @dougwilson https://github.com/dougwilson also manages, and he raises valid concerns about the huge matrix of supported platforms and versioning that come inherently as adding a node package into the mix from outside.

I didn't feel comfortable rewriting or augmenting existing package at the time, but for now I'd suggest installing the branch with the external package, running it to see the output it contains, copy/pasting the output to a github gist, reinstalling the generator from npm and just copy and pasting from the gist.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/expressjs/generator/issues/162#issuecomment-348339746, or mute the thread https://github.com/notifications/unsubscribe-auth/ARj5GeJNvYOP_PdAQc43EliSDzf1oQbsks5s7ypggaJpZM4N6sXz .