expressjs / multer

Node.js middleware for handling `multipart/form-data`.
MIT License
11.57k stars 1.05k forks source link

Big file upload error multer google cloud storage #737

Open jaman99 opened 5 years ago

jaman99 commented 5 years ago

//Google cloud upload storage

Memory Leak

if(req.videocheck ){

var myvideo=req.files.myvideo[0].originalname;

var ext = path.extname(''+myvideo+''); const gcsname =Date.now()+ext;

      const file = bucket.file(gcsname);

      const stream = file.createWriteStream({
        metadata: {
          contentType:req.files.myvideo[0].mimetype
        },
        resumable: false
      });

      stream.on('error', (err) => {
        req.files.myvideo[0].cloudStorageError = err;
        req.videocheck=false;
        console.log('Error function hit.....');
        next(err);
      });

    stream.on('data',(data)=>{
    cosnole.log('data hit..');
    console.log(data)

    })

      stream.on('finish', () => {
        req.files.myvideo.cloudStorageObjectimg = gcsname;
        file.makePublic().then(() => {
          req.files.myvideo[0].cloudStoragePublicUrlimg =getPublicUrl(gcsname);
          req.videocheck=true;
          next();
        });
      });

 stream.end(req.files.myvideo[0].buffer);

}else{

req.videocheck=false; next(); }

hcz commented 5 years ago

It looks like busboy's issue mscdex/busboy#143