Discussion: Proposed Changes for expressjs/response-time Next Major Version

carpasse commented 2 months ago

This issue aims to discuss potential changes for the next major version of expressjs/response-time.

Key Areas to Consider:

API Simplification - BREAKING CHANGE

Standardized Options Object: Remove the deprecated approach of passing a single number to the middleware. Going forward, users should provide options as an object:
```
app.use(responseTime({ digits: 3 })); // Set digits to 3
```
1. Node.js Version Support - BREAKING CHANGE Drop support for Node.js < 18: We propose discontinuing support for Node.js versions below 18 (LTS). This ensures alignment with the latest security patches and modern features of Node.js.

Dependency Management Upgrade dependencies: Update all project dependencies to their latest compatible versions, ensuring access to bug fixes, security updates, and compatibility with Node.js 18+.
Code Modernization - BREAKING CHANGE Migrate to new ES syntax: Consider refactoring the codebase to leverage modern ES syntax, improving maintainability and alignment with contemporary Node.js practices.

UlisesGascon commented 2 months ago

Sounds like a good plan. +1 from me. cc: @expressjs/express-tc

wesleytodd commented 1 week ago

Other than number 4, I think each of those could land as individual PRs. If you could open a PR or a new issue to discuss what new features you think would add value then I would like to discuss that part separately.

expressjs / response-time

Discussion: Proposed Changes for expressjs/response-time Next Major Version #25

Key Areas to Consider: