expressobits / inventory-system

Modular inventory system for godot 4 with nodes, compatible with multiplayer, separate logic from the UI, Using items as separate resources.
MIT License
459 stars 31 forks source link

Move the demos to a different repo #47

Closed Blade67 closed 1 year ago

Blade67 commented 1 year ago

Resons

Better organisation

This makes it easier to find demos and adds the benefit of being able to test updates without changing the project Creating a clean project containing (for example) the FPS demo and having the addon as a dependency (maybe even a Github Submodule? See here) would make things considerably more accessible. One of the main reasons people avoid great addons like these is the lack of documentation. Add to it the fact that the demos are hidden deep within the project; it is easy to see why people turn away, no matter how great this addon is.

Engine behavior

Godot currently loads the demo projects and their classes, which might not be desired. This is especially bothersome when class names override each other. (ie. class_name Player ) Add to this the fact that inexperienced Godot users may try to use this addon to simplify their project, the confusion of why things break, how to use it, etc. they're more likely to turn away from the addon or even the engine.

Packaging size

Having the demos in a different repo avoids packaging all the demo files in the final product. I'm aware that it is possible to exclude files from being packed, but due to the engine behaviors mentioned above, this could and most likely will break the project in unexpected ways.

scriptsengineer commented 1 year ago

I agree 100% with this approach, I was currently analyzing with Ark2000 (from Ark2000/PankuConsole) about mirroring the repository to be used as a submodule.

scriptsengineer commented 1 year ago

Created (https://github.com/expressobits/inventory-system-demos) and sent to the asset lib as a project, the addon will only be updated once the project is approved in the asset lib

scriptsengineer commented 1 year ago

Move addons/inventory system contents to root folder (submodule purposes) in main and develop branch