search

expressobits / inventory-system

Modular inventory system for godot 4 with nodes, compatible with multiplayer, separate logic from the UI, Using items as separate resources.
MIT License
407 stars 26 forks source link

Assure inventory system changes #77

Closed FlauschBert closed 8 months ago

FlauschBert commented 8 months ago

Hi, I tried out the addon the first time today. Nice work so far :)

I noticed that if CharacterInventorySystemis readied before the InventorySystemUIthen no handler, no crafter and so on is set. This I fixed by calling the changed functions. I am not sure whether the addon branch is right here ...

scriptsengineer commented 8 months ago

Great, this solves the problem where I ended up having to add a delay for the player to start, however this has a counterpoint, the InventorySystem will not always have everything configured, for example the multiplayer version, in which the player starts later. Adding a check if the inventory system components are null will solve the problem, it would also help if you modify pr to be from the main branch. (But only if you can, as your pr was from the addon -> main branch)

FlauschBert commented 8 months ago

Okay. I made another proposal in #84