Error trying to open CharacterInventorySystem scene in new project

[levidavidmurray]

I can replace the resources easy enough, but I'm assuming that references to demo resources in core aren't intended.

I would create a PR, but I'm not exactly sure of your workflow for core changes against the demo project and then committing outside the demo project. If you could guide me in the right direction for core contributions that'd be great!

[scriptsengineer]

Yes, it is not intentional, a pr for this must be done for the main branch, which contains only the core, without the godot project. It's easy to add it as a git submodule.

[levidavidmurray]

I was more curious as to how (or even if) you're developing against the demos branch project.

I'm quite familiar with git, but I think I've only run into submodules once up to this point, so bear with me.

I have my fork of this repo currently checked out to demos, which obviously has addons/inventory-system committed. So, I'd replace the existing addons/inventory-system with a git submodule of the same repo, but checked out to main, develop, etc.?

Would replacing addons/inventory-system with a submodule not result in changes to the top level demos branch?

[scriptsengineer]

Yes, it's expensive, I keep two repositories downloaded, one that has the demo, but has a module installed and I only commit it to develop/master, and another with a repository that is just a mirror where I put things in the addon/demos, that way it stays calm for me, but if you think it's too complex you can do it on the demos, and I'll pass it on to the master with cherry picks.

[levidavidmurray]

Got it. I figured it had to be something like that. Do you have to recreate the submodule when you want to pull in the latest demos changes?