expresstechsoftware / connect-memberpress-discord-add-on

This add-on enables connecting your MemberPress enabled website to your discord server. Now you can add/remove MemberPress members directly to your discord server roles, assign roles according to your member levels, unassign roles when they expire, change role when they change membership.

GNU General Public License v2.0

4 stars 1 forks source link

work on trasaction complete aug 3 2021 #28

Closed aashishmeenaets closed 2 years ago

aashishmeenaets commented 2 years ago

work on #27

ravisoni6262 commented 2 years ago

Membership expiration having 2 DM schedules, one for expiry and one for cancel.
on New signup role is not being assigned.
Upon expiry, the default role is also gone, but the non-member setting was set to YES so the member should have the default role assigned.

ravisoni6262 commented 2 years ago

DB entry having a wrong key name. the membership_id is missing from the key name.

Untitled

ravisoni6262 commented 2 years ago

One put role API not having role ID incall:

Untitled

ravisoni6262 commented 2 years ago

File : memberpress-discord/public/class-memberpress-discord-public.php Method: ets_memberpress_discord_as_handler_memberpress_complete_transaction Line: if ( $mapped_role_id && $expired_level_id == false && $cancel_level_id == false ) {

How come expired_level_id
How come cancel_level_id variables come into this method?

ravisoni6262 commented 2 years ago

mepr_pre_delete_transaction should be written inside the admin module of the plugin.
Method having wrong params in description: 'ets_memberpress_discord_set_member_roles'
$default_role = sanitize_text_field( trim( get_option( '_ets_memberpress_discord_default_role_id' ) ) );
You are using the wrong key name _ets_memberpress_discord_default_role_id it does not have an underscore.
Rename Allow none members --> Allow non-members
$cancel_level_id variable is not defined in the method: ets_memberpress_discord_set_member_roles
Welcome DM message is not working

ravisoni6262 commented 2 years ago

I fixed the following:

[08-Aug-2021 12:37:38 UTC] PHP Warning: Undefined variable $is_schedule in /Applications/MAMP/htdocs/memberpress/wp-content/plugins/memberpress-discord/admin/class-memberpress-discord-admin.php on line 731
After expiry member default role is being removed, but the default role is set and allow non-member is set to YES
New signup did not put default role.
Why writing $is_schedule variable instead you need to pass TRUE or FALSE. $plugin_public->put_discord_role_api( $user_id, $mapped_role_id, $is_schedule );