Feature/3 developing role mapping tab

[ravisoni6262]

Review:

• On the roles mapping tab remove Allow non-member settings, because the ultimate member is not a membership plugin.
• Remove code that saves the above settings.
• Remove commented code is not needed.
• Create a minified version of JS and link it.
• Create a minified version of CSS and link it.

[ravisoni6262]

Case:

• Since you are saving role mapping with index of UM role.
• {"ultimate-member_level_id_0":"800663607074750475","ultimate-member_level_id_1":"857193694129684490"}
• I deleted 0 index role and create new role whose index become 0, but the role automatically was mapped to new role.

Expected:

• instead of saving the index of the loop using the value itself, like "ultimate-member_level_id_ultimaterole":"800663607074750475"

You can convert the role name to lowercase and replace space with a hyphen (-)

[ravisoni6262]

Review:

• Before accessing any variable we must first check and verify nonce value.
• I see you have added a file class-ultimate-member-discord-api.php It is not needed, you can perform API actions inside the plugin admin or public wherever is suitable and needed.
• I'm getting fatal error:
• [29-Oct-2021 10:17:49 UTC] PHP Fatal error: Uncaught Error: Call to undefined method Ultimate_Member_Discord_API::create_discord_auth_token() in /Applications/MAMP/htdocs/pmpro/wp-content/plugins/ultimate-member-discord-add-on/includes/class-ultimate-member-discord-api.php:116

[ravisoni6262]

When I'm activating the plugin, it is sending some headers which are causing issues.

[ravisoni6262]

Remove this: "Note: Inactive levels will not display"

[ravisoni6262]

There is no need for this file: class-ultimate-member-discord-api.php

API code should be written to the file where it is needed, either in the frontend or backend.

[ravisoni6262]

Review:

• Remove line 118 to include a separate file from the file class-ultimate-member-discord-add-on.php
• The code should be properly indented, use WordPress coding standards in your Visual Studio editor.
• Move the API class method ets_ultimatemember_discord_load_discord_roles to admin/class-ultimate-member-discord-add-on-admin.php
• FATAL ERROR [09-Dec-2021 10:21:59 UTC] PHP Fatal error: Uncaught TypeError: Cannot access offset of type string on string in /Applications/MAMP/htdocs/pmpro/wp-content/plugins/ultimate-member-discord-add-on/public/class-ultimate-member-discord-add-on-public.php:620
• The Tabs in the admin are always showing the Role mapping tab, instead, it should show the tab which is active.

[ravisoni6262]

Review:

Please see the screenshot, I'm getting an Error, but the color of the error button should be RED.