extdn / extdn-phpcs

PHP CodeSniffer rules
81 stars 10 forks source link

Rule: Analyse Missing Modules in app/etc/config.php #43

Open larsroettig opened 6 years ago

larsroettig commented 6 years ago

Rule

If exist app/etc/config.php we should analyse the File for missing modules.

Use Case if use extdn-phpcs for a Magento costumer project

schmengler commented 6 years ago

Seems out of scope for a tool that targets code quality, but let's discuss

jissereitsma commented 6 years ago

Discussed this in a meeting of July 30th. It seems out of scope for PHPCS (another tool would be better suitable) and out of scope for the focus of this project (extension quality). Suggested was to create a bin/magento command instead for this - like module:validate. This command could check for registration.php files to see if the module is there.