search

extdn / github-actions-m2

137 stars 46 forks source link

Fix module_source input, fixes #82 #101

Closed sprankhub closed 8 months ago

sprankhub commented 8 months ago

@jissereitsma, could you review this? Or alternatively, @fredden? :)

jissereitsma commented 8 months ago

Isn't this a breaking change either? The script could be receiving a MODULE_SOURCE or INPUT_MODULE_SOURCE depending on the structure of the YAML file. So I'd rather just add another line like this to set the MODULE_SOURCE properly, instead of renaming the variable everywhere:

test -z "${MODULE_SOURCE}" && MODULE_SOURCE=$INPUT_MODULE_SOURCE

This way, either way still works. With this addition somewhere in the top, the lines below (as mentioned in your PR) still are the same.

It is similar to the change suggested by @fredden - except for the comment on the breaking change, which I would try to prevent: https://github.com/extdn/github-actions-m2/pull/109