search

extdn / github-actions-m2

137 stars 46 forks source link

Check files within Magento project root #113

Closed fredden closed 5 months ago

fredden commented 5 months ago

While working on a Magento module with the PHPStan GitHub Action from this repository, I am getting some unexpected errors like "return statement is missing" when it isn't missing. I've done a little testing locally and when I inspect the same files within the Magento root, these extra errors don't show up. I have tested that (when I introduce an intentional issue) PHPStan still reports other issues with this set-up.

Here's an example run with invalid results https://github.com/Ethan3600/magento2-CronjobManager/actions/runs/8394567803/job/22992004531?pr=206

fredden commented 5 months ago

@sprankhub please can you get GitHub Actions to build new images for this? (ie, re-run the workflow.) At the time when you merged this change in, Magento 2.4.7 wasn't yet released, so the automated build failed. Now that Magento 2.4.7 has been released the builds should complete successfully.

https://github.com/extdn/github-actions-m2/actions/runs/8513858728/job/23318385153

sprankhub commented 5 months ago

Done and seems to work: https://github.com/extdn/github-actions-m2/actions/runs/8513858728/job/23614141036

Thanks again!