search

extdn / installer-m2

Universal extension installer for Magento 2, see introductory blog post here
https://fooman.com/blog/introducing-the-extdn-installer-for-magento-2.html
MIT License
24 stars 0 forks source link

Detecting deployment mode properly #1

Closed jissereitsma closed 5 years ago

jissereitsma commented 5 years ago

Currently, the MAGE_MODE environment variable is used for detecting the current mode (if I'm not mistaken). In my personal environments, I don't use this variable but simply rely on the right variable in app/etc/env.php.

fooman commented 5 years ago

We should be good. A bit of a double up of terms.

I am reading app/etc/env.php into env here https://github.com/extdn/installer-m2/blob/master/extdn_installer.php#L176 and then check it here for example https://github.com/extdn/installer-m2/blob/master/extdn_installer.php#L262