search

extemporelang / extemporelang.github.io

Extempore docs website
MIT License
71 stars 26 forks source link

Add search function #22

Closed cyblue9 closed 5 years ago

cyblue9 commented 5 years ago

Hi @benswift !

Correspond to https://github.com/extemporelang/extemporelang.github.io/issues/6

Completed!!! image is following: https://photos.app.goo.gl/P6UTsCiCfqBvMmQs6

And made minor changes of site header.

note Github page is a static site service. Therefore, It can't hide the API Key. However, there is no problem with security. For example: vuejs docs (https://github.com/vuejs/vuejs.org/blob/53b11fbbef932f3ba2cf0596fe198d6be8d70e23/themes/vue/layout/layout.ejs#L118) So, It is not a mistake to see the API Key.

Pease review!

benswift commented 5 years ago

great stuff, and good call on the API key visibility

you should have a commit bit for the main repo - so for mi or tweaks and improvements feel free to just push them up :)

cyblue9 commented 5 years ago

Thank you for merge!

OK, I will push without your review :)