search

extemporelang / extemporelang.github.io

Extempore docs website
MIT License
71 stars 26 forks source link

search box doesn't do anything #6

Closed benswift closed 5 years ago

benswift commented 6 years ago

the html for the (top-right) search field is in _includes/topnav.html, and should probably just do a google search with site:extemporelang.github.io but at the moment it does nothing.

cyblue9 commented 5 years ago

Hi @benswift!

I am interested in improvement of this problem!

Two libraries are conceivable for the inside search. Two libraries is and lunr.js and algolia.

I think algolia is better. Because, instant search is nice function and Usingalgolia is probably easy. If there is no problem with the free plan.

What do you think?

benswift commented 5 years ago

Hmm, good ideas there. I guess the other option is that we just have it point to a straight search on Google (with site:extemporelang.github.io added). However, it's very unlikely that we'd hit the Algolia limits on the free plan. So perhaps let's go with that option :)

I'm sorry that I haven't approved the other PR yet either, but will have some time to look at it later this week.

cyblue9 commented 5 years ago

Thank to replay😁

I guess the other option is that we just have it point to a straight search on Google (with site:extemporelang.github.io added).

It's good. This option is easy to implement. But, As a disadvantage

It might be not good as UI.

However, it's very unlikely that we'd hit the Algolia limits on the free plan. So perhaps let's go with that option :)

Oh, it is possible on the free plan! I found Algolia for Jekyll. Implementation may be easy with this. If we use Alogolia, need to create Algolia account. Which is better to create Algolia account, by extempore account or my account? (If possible, Please to create Algolia account by extempore github account and to teach me API key by some means.)

I'm sorry that I haven't approved the other PR yet either, but will have some time to look at it later this week.

No problem😃

cyblue9 commented 5 years ago

Ping... @benswift

benswift commented 5 years ago

Ok, I've signed up for algolia. What's the best (encrypted) way to send the credentials to you? Do you have signal/whatsapp?

benswift commented 5 years ago

Also, you should have access to the main docs website repo: I added you to the docs sub-team under the Extempore organisation on GH.

cyblue9 commented 5 years ago

Ok, I've signed up for algolia. What's the best (encrypted) way to send the credentials to you? Do you have signal/whatsapp?

Sorry, I don't have signal or whatsapp. (They are not used much in Japan) Do you have another idea? If you don't have another idea, I will install whatsapp.

Also, you should have access to the main docs website repo: I added you to the docs sub-team under the Extempore organisation on GH.

Thanks! 😀

benswift commented 5 years ago

Well, we could do some pgp shenanigans. Or you could just get Whatsapp - what's your preference?

cyblue9 commented 5 years ago

Thank you for suggesting another idea! I knew GPG for the first time. It looks good. If you agree GPG, I will create my public key and private key, tell you my public key. OK?

benswift commented 5 years ago

Yep, sounds good.

cyblue9 commented 5 years ago

I sent mail to you. Please replay 😄

benswift commented 5 years ago

added in #22