search

extemporelang / kiss_fft

A fork of KissFFT (https://github.com/mborgerding/kissfft) with CMake support
BSD 3-Clause "New" or "Revised" License
27 stars 14 forks source link

Added shared lib generation for linux #2

Closed mmaul closed 10 years ago

mmaul commented 10 years ago

Modified to also generate so for Linux. Generalized the shared library target so you should test to make sure it still works for OSX. Shared libs generated in shared directory

benswift commented 10 years ago

Hi Mike

Thanks for your hard work on this. However, I'm not going to merge it since it's really an improvement to the KissFFT source, so it should be submitted as a patch to that project (KissFFT sourceforge page), I'm just the maintainer of the homebrew formula. The idea is to keep the homebrew formula as slim as possible, and have improvements like that contributed upstream so that everyone benefits.

Let me know if you have any luck (or any troubles) getting the makefile added to KissFFT, and I'll update the homebrew formula to use it. That would be awesome.

Cheers, Ben

On 22 Feb 2014, at 5:31 pm, Mike Maul notifications@github.com wrote:

Modified to also generate so for Linux. Generalized the shared library target so you should test to make sure it still works for OSX. Shared libs generated in shared directory

You can merge this Pull Request by running

git pull https://github.com/mmaul/kiss_fft master Or view, comment on, or merge it at:

https://github.com/benswift/kiss_fft/pull/2

Commit Summary

Updated make file for constructions of shared lib for linux iMissing / Missing lib path busted link File Changes

M Makefile (55) A shared/.gitignore (4) Patch Links:

https://github.com/benswift/kiss_fft/pull/2.patch https://github.com/benswift/kiss_fft/pull/2.diff — Reply to this email directly or view it on GitHub.