extend-chrome / jest-chrome

A complete mock of the Chrome API for Chrome extensions for use with Jest.

MIT License

124 stars 24 forks source link

Support v3 promises. #23

Open derekrprice opened 1 year ago

derekrprice commented 1 year ago

Community guidelines:

[x] I have read and understand the contributing guidelines and code of conduct

This PR contains:

[ ] bugfix
[x] feature
[ ] refactor
[ ] documentation
[ ] other

Are tests included?

[x] yes (bugfixes and features will not be merged without tests)
[ ] no

Breaking Changes?

[ ] yes (breaking changes will not be merged unless absolutely necessary)
[x] no

List any relevant issue numbers:

21

Description

Adds support for returning promises for functions accepting optional callbacks.

aThorp96 commented 1 year ago

Thank you for starting this PR. This is sorely needed.

tscislo commented 10 months ago

Any chance for this to get merged in?

tmhrbr commented 3 months ago

@jacksteamdev can we merge this please?