extend-chrome / messages

An API for Chrome Extension messages that makes sense.
https://www.npmjs.com/package/@extend-chrome/messages
MIT License
74 stars 8 forks source link

Wrong type for getMessage(...).wait #19

Open asjir opened 6 months ago

asjir commented 6 months ago

Google search terms

I only went through files here.

Describe the bug

getMessage(...).wait will return the same i.e. [data, sender] tuple, as does firstValueFrom(getMessage(...).stream) but the types are annotated incorrectly

How do we reproduce?

const [_, stream, wait] = getMessage("a") const waited = wait() const streamed = firstValueFrom(stream)

Expected behavior

the same type

Actual behavior

the type infer to Promise and Promise<[string, chrome.runtime.MessageSender]> even though the output is the same

Screenshots

Please complete the following information:

Additional context