Closed amjadr360 closed 1 year ago
Generally, this looks good to me in my testing.
Evaluate button interactivity: Previously, buttons lacked noticeable hover effects. Insert the button block onto a page Interact with buttons to check the newly added hover, focus, and active effects, ensuring an improved visual appeal and user experience.
One thing I noticed was that the secondary button didn't seem to have a hover effect. Just the primary. Is that intentional?
I also noticed two instances where the hover color made the button itself difficult to see.
The Kong Kong variation is the most extreme:
Cairo is not as bad. Maybe it's fine. What do you think?
One thing I noticed was that the secondary button didn't seem to have a hover effect. Just the primary. Is that intentional?
The secondary button (Outline button style) is a variation of the button. Right now, by default, WordPress does not support the hover effect for the Outline button style. Yes, it's a good idea to add the hover effect for the secondary button, So we add the hover effect through custom CSS.
The Kong Kong variation is the most extreme:
Fixed
Cairo is not as bad. Maybe it's fine. What do you think?
It's fine, but I think it will not meet accessibility guidelines. Updated the hove color to white.
@clubkert, Made some tweaks based on your feedback. Could you please review the changes once more?
Looks good to me.
This PR:
How to test it best: