Add Logo blocks in the headers

extendify / extendable

WordPress block theme for Full Site Editing (FSE) brought to you from the team at Extendify.

https://wordpress.org/themes/extendable

26 stars 1 forks source link

Add Logo blocks in the headers #95

Closed amjadr360 closed 1 year ago

amjadr360 commented 2 years ago

Discussion: https://github.com/extendify/user-research/issues/6

This PR adds the logo to the header-title-nav-button.html and header-title-social-nav.html headers.

richtabor commented 2 years ago

Could you also adjust this here (menu/social spacing):

amjadr360 commented 2 years ago

Just for the information:

The spacing issue appears when the Gutenberg plugin is active. I think due to step spacing.

For that, we need to update the theme.json too.

amjadr360 commented 2 years ago

Could you also adjust this here (menu/social spacing):

This spacing issue is related to Gutenberg V14.2.0 because CSS for the gap (Block Spacing) is not rendering properly. This issue only appears in the Site Editor. If we set custom spacing in numeric, CSS renders fine.

I think it's due to Gutenberg V14.2.0 switched to using numbers: https://github.com/WordPress/gutenberg/pull/44247