search

extendr / helloextendr

Minimal Example of the Rust extendr Crate
Other
20 stars 10 forks source link

Add -lntdll #19

Closed dfalbel closed 1 year ago

dfalbel commented 1 year ago

As per: https://github.com/extendr/extendr/pull/560

Ilia-Kosenkov commented 1 year ago

I suggest you remove R 4.1 since it is already outdated

dfalbel commented 1 year ago

You mean from the checks? I guess you still need the -lntdl to be able to build on R4.3 though, right?

Ilia-Kosenkov commented 1 year ago

I mean CI run that uses windows-R4.1

yutannihilation commented 1 year ago

I think this pull request is not responsible for the failure on R 4.1. Let's fix it in another PR if needed.

So, you can ignore the failure here, but I'm against tweaking the files by hand. I think you can regenerate these by the latest rextendr (and it should be automated ideally).

Ilia-Kosenkov commented 1 year ago

The reason it fails for R4.1 is that Rust 1.70 does not work with Rtools 4.2 ore earlier.

yutannihilation commented 1 year ago

Rust 1.70 does not work with Rtools 42

To be precise, it works, but with warnings, which make the CI fail.

Ilia-Kosenkov commented 1 year ago

Ok, sounds fair, I'll bypass this and merge PR as is. We need to address the CI issue separately.