search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
186 stars 27 forks source link

Lean on withr #109

Closed malcolmbarrett closed 2 years ago

malcolmbarrett commented 3 years ago

106 adds withr to imports, so I'd like to lean on it for some of its state-management functions in place of on.exit() and friends.

Ilia-Kosenkov commented 3 years ago

@malcolmbarrett, please avoid this fragment for now https://github.com/extendr/rextendr/blob/5ee2062d9134084a99e68266271985e360244d6e/R/source.R#L223-L233 I have a PR ready that improves rtools detection and uses {withr} instead of on.exit in invoke_cargo function.

malcolmbarrett commented 3 years ago

Got it, thanks!