Fixing incorrect arguments passed to invoke_cargo() and system2()

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically

https://extendr.github.io/rextendr/

Other

196 stars 28 forks source link

Fixing incorrect arguments passed to invoke_cargo() and system2() #112

Closed Ilia-Kosenkov closed 3 years ago

Ilia-Kosenkov commented 3 years ago

Fixed #111. Fixes a bug introduced by copy-pasting/moving code around in #38 by me.

The name of the variable that controls the output of system2 is changed from confusing stdout to simply out. It is passed to both stdout and stderr.

clauswilke commented 3 years ago

Could you add a few comments documenting the invoke_cargo() function? As is, I don't really understand what the stdout and stderr arguments do, and that makes is difficulty for me to evaluate the PR.

Ilia-Kosenkov commented 3 years ago

@clauswilke, is it better now?

clauswilke commented 3 years ago

Yes, looks good to me. Thanks!