extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
186 stars 27 forks source link

Cleanup of minor issues #127

Closed Ilia-Kosenkov closed 3 years ago

Ilia-Kosenkov commented 3 years ago

This PR addresses small issues in string formatting.

  1. [Windows] when dynamically compiling Rust code, the build directory was displayed to the user using backslashes (likes C:\path\to\temp\dir). However, by convention we use forward slashes everywhere, so I changed it to be consistent with all other displayed paths. Forward slash notation allows to copy-paste paths as is, backslashes are treated as escapes sequences and often require additional escaping.
  2. [Follow up to #125] A function in rust_eval_deparse() was previously declared to please R CMD check, but is no longer used. I missed this yesterday when pushed PR. It is now safely removed.
  3. If {knitr} is absent, an error message is displayed if eng_impl() is somehow invoked. I replaced "knitr" with "{.pkg knitr}", which uses inline markdown to highlight this is a package.