search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
186 stars 27 forks source link

Set CARGO_HOME in Makevars #133

Closed yutannihilation closed 1 year ago

yutannihilation commented 3 years ago

I got this review comment from CRAN:

Checking this creates ~/.cargo sized 82MB, in violation of the CRAN Policy. Please fix as necessary and resubmit.

It seems we need to set CARGO_HOME to somewhere inside package directory and delete the cache after installation.

c.f. https://github.com/r-rust/gifski/blob/6b86cc6b60abbc2294db821f27cae37413df70c2/src/Makevars#L9

CGMossa commented 2 years ago

Is this still the case?

yutannihilation commented 2 years ago

What do you mean? The CRAN Policy is still there.

yutannihilation commented 1 year ago

Seems already resolved by https://github.com/extendr/rextendr/pull/233