extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
184 stars 27 forks source link

Add_optim_profile #194

Closed CGMossa closed 2 years ago

CGMossa commented 2 years ago

As mentioned in #173, this adds a "hyper" optimised build profile, and a new argument to enable this.

CGMossa commented 2 years ago

Note that I've updated the edition used to 2021.

Ilia-Kosenkov commented 2 years ago

Not a fan of optim, but rust profile names are strange (neither full nor abbreviated). So if there is no better (short) word, lets make it optim.

CGMossa commented 2 years ago

Yeah I don't like optin either. I'd like to wait for someone creative to present a better name for it.

Ilia-Kosenkov commented 2 years ago

As a stupid alternative, perhaps perf will do? Does not conflict with pre-existing default profiles, signals enhanced performance, and is widely used as an abbreviation for performance.

Ilia-Kosenkov commented 2 years ago

~@CGMossa , can you resolve a conflict here?~

CGMossa commented 2 years ago

I'll squash & merge once the tests show success after the conflict have been resolved.

CGMossa commented 2 years ago

Fixes #173