Closed yutannihilation closed 1 year ago
Oh, this looks much better than my attempts! A comment/suggestion: the linker links to lgcc_eh
and to lgcc_s
, but in the commenting text you write that it needs libgcc_eh
and libgcc_a
. I think the second one has a typo, since it should be libgcc_eh.a
and libgcc_s.a
.
I also restarted the CI. I intend to do it a couple of times in hopes we can reproduce the issue if it is still there.
Thanks for catching! Yes, that was a typo. Since this pull request also removes libgcc_s
as well, I removed it from the sentences.
For future reference, libgcc_s
is not necessary for an R package, but it seems it's required when proc_macro = true
. We need to care about this difference on extendr repo.
Close #209