Closed yutannihilation closed 1 year ago
Also, we need to check what toolchain is used for dynamic compilation with rextendr::rust_source()
and other functions,.
NVM, it uses system's default https://github.com/extendr/rextendr/blob/f627e943bfb507192b5599d1e331448c80049906/R/zzz.R#L20
If this works, I guess we should drop TOOLCHAIN
from Windows completely. We arrived to using default toolchains on all platforms, so no need to override it via an additional parameter. If there ever is a need to use different toolchain, we should address it by using rustup default what-we-need
Thanks, sounds a good idea.
Hmm, it seems something is wrong with r-hub today so the CI fail... I'll retry tomorrow.
Yay, I retried and all the CI passed. I think the current CI setting is a bit overkill; we can drop some combinations that are less important (i.e. mainly test with the MSVC toolchain, as it will be our main target, and keep only one case with GNU toolchain). I'll tweak later.
This should be ready for review now.
Thanks! I already use this in https://github.com/extendr/extendr/pull/439
Related to https://github.com/extendr/extendr/issues/437
+$(TOOLCHAIN)
) from the template