extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
181 stars 27 forks source link

added optimisations to Cargo.toml #226

Closed alexhroom closed 1 year ago

alexhroom commented 1 year ago

Adds some compiler optimisations to Cargo.toml. This should remove the R CMD CHECK NOTE on the compiled code being very large.

CGMossa commented 1 year ago

We have generally decided against this. The gains vs. drawbacks are not the same for every use-case. See this issue for more as to how we decided on this: https://github.com/extendr/rextendr/issues/173 #173

alexhroom commented 1 year ago

@CGMossa will create an issue on this topic instead (at @Ilia-Kosenkov's suggestion on discord)- it isn't the same issue as #173 especially now CRAN is more relevant than it was previously