search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
181 stars 27 forks source link

A function to update package version in `src/rust/Cargo.toml` #228

Closed eitsupi closed 1 year ago

eitsupi commented 1 year ago

At the moment I think the version of Cargo.toml is still 0.1.0 unless it is updated manually, should it be updated in general? If so, it would be useful to be able to update it along with the R package version with a function like usethis::use_version.

_Originally posted by @eitsupi in https://github.com/extendr/helloextendr/pull/16#discussion_r1063984447_

yutannihilation commented 1 year ago

I think rextendr should not modify other than then extedr-wrappers.R. Cargo.toml is supposed to be edited by the package author, so trying to modify it might cause unexpected results.

Ilia-Kosenkov commented 1 year ago

The question is, is there a scenario when the crate version is different from the package version? Since rust code could be only a part of the package, I can imagine someone making changes only to R code and not touching Rust code, which might qualify for bumping R package version but keeping crate version unchanged.

eitsupi commented 1 year ago

Perhaps this is not valuable enough, so I will close it.