search

extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
181 stars 27 forks source link

Use Rtools43 #231

Closed yutannihilation closed 1 year ago

yutannihilation commented 1 year ago

This pull request is a part of https://github.com/extendr/extendr/issues/442.

r-lib/actions now supports Rtools43 and uses it by default for R > 4.2 (c.f. https://github.com/r-lib/actions/commit/740a0e7ce930b6357f16388c0b2acee8337adb01). So, this pull request removes the specification of rtools-version: '42' on the R-devel runners.

Also, this pull request stops relying on pkgbuild to detect RTOOLS4x_HOME for R >=4.2. pkgbuild doesn't support Rtools43 yet, and all it does is just to check RTOOLS4x_HOME (source code), so we can simply do the same thing.

Ilia-Kosenkov commented 1 year ago

Since it is a significant change, I suggest you mention this in the changelog.

yutannihilation commented 1 year ago

I see, thanks.