extendr / rextendr

An R package that helps scaffolding extendr-enabled packages or compiling Rust code dynamically
https://extendr.github.io/rextendr/
Other
180 stars 27 forks source link

`document` doesn't react to all files changes #247

Open CGMossa opened 1 year ago

CGMossa commented 1 year ago

Via #246 rextendr::document doesn't re-compile in case you change .cargo/config.toml-file.

The detection of needing to compile comes from pkgbuild. This extra rust feature was provided by way of https://github.com/r-lib/pkgbuild/commit/2fd13d9a3b45332db9a95ab2cf092a5cd1d0dc60

Here it is clearly stated that rs-files and Cargo.toml are the only sensitive ones to recompilation.

There was talk of adding a configurable feature via DESCRIPTION-file, but this was abandoned.

Do we suggest the following additions:

I'd rather we gather the exact glob-list before making an issue over at pkgbuild.

Ilia-Kosenkov commented 1 year ago

How about we track *rs and *toml? Feels like all of them should affect compilation, no? And by we I mean ask {pkgbuild} :)